Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/pinnwand: init; steck: init at 0.5.0; nixos/tests/pinnwand: init #89444

Merged
merged 5 commits into from Aug 14, 2020
Merged

nixos/pinnwand: init; steck: init at 0.5.0; nixos/tests/pinnwand: init #89444

merged 5 commits into from Aug 14, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Jun 3, 2020

Motivation for this change

Adds

  • module for pinnwand, the pastebin server
  • package for steck, it's command line client
  • a test case for both:
    • pasting /etc/machine-id
    • downloading it to /tmp/machine-id
    • make sure they don't differ
    • trigger the removal link
    • make sure the paste is gone
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt mentioned this pull request Jun 8, 2020
Merged
10 tasks
@mweinelt
Copy link
Member Author

mweinelt commented Jun 21, 2020 •
edited

Hm, since moving to pyproject format in 545ce6e I've lost bin/pinnwand in $out 😕

Edit: Apparently I lost everything 😕. The pyproject file is here https://github.com/supakeen/pinnwand/blob/master/pyproject.toml.

.
./lib
./lib/python3.8
./lib/python3.8/site-packages
./lib/python3.8/site-packages/UNKNOWN-0.0.0.dist-info
./lib/python3.8/site-packages/UNKNOWN-0.0.0.dist-info/METADATA
./lib/python3.8/site-packages/UNKNOWN-0.0.0.dist-info/RECORD
./lib/python3.8/site-packages/UNKNOWN-0.0.0.dist-info/direct_url.json
./lib/python3.8/site-packages/UNKNOWN-0.0.0.dist-info/AUTHORS.rst
./lib/python3.8/site-packages/UNKNOWN-0.0.0.dist-info/INSTALLER
./lib/python3.8/site-packages/UNKNOWN-0.0.0.dist-info/LICENSE
./lib/python3.8/site-packages/UNKNOWN-0.0.0.dist-info/WHEEL
./lib/python3.8/site-packages/UNKNOWN-0.0.0.dist-info/top_level.txt
./nix-support
./nix-support/propagated-build-inputs

@mweinelt mweinelt mentioned this pull request Jun 21, 2020
Open
jonringer
jonringer reviewed Jun 21, 2020
View reviewed changes
pkgs/servers/pinnwand/default.nix Outdated Show resolved Hide resolved
pkgs/servers/pinnwand/default.nix Outdated Show resolved Hide resolved
@mweinelt
Copy link
Member Author

mweinelt commented Jul 7, 2020

@FRidh Can I kindly ask you to look into this? You seem to be familiar with the pyproject format. #89444 (comment)

jonringer
jonringer approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python packaging LGTM

not sure about service/test

aanderse
aanderse requested changes Jul 8, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few minor comments but overall very nice module.

nixos/modules/services/misc/pinnwand.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/pinnwand.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/pinnwand.nix Show resolved Hide resolved
nixos/modules/services/misc/pinnwand.nix Show resolved Hide resolved
nixos/modules/services/misc/pinnwand.nix Show resolved Hide resolved
nixos/modules/services/misc/pinnwand.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/pinnwand.nix Show resolved Hide resolved
@mweinelt
Copy link
Member Author

mweinelt commented Jul 8, 2020

python packaging LGTM

@jonringer Except the package is empty, see #89444 (comment).

@FRidh
Copy link
Member

FRidh commented Aug 6, 2020

I think its not working because build-backend = "poetry.masonry.api" is missing under [build-system]. but I have not tested it.

@mweinelt
Copy link
Member Author

mweinelt commented Aug 6, 2020 •
edited

That is spot on, that made it work. Thank you.

@mweinelt mweinelt force-pushed the pinnwand-module branch 2 times, most recently from d4b3266 to e255e97 Compare August 6, 2020 11:40
@FRidh
Copy link
Member

FRidh commented Aug 6, 2020 •
edited

Please report the issue upstream because it is a bug causing other front-ends aside from poetry (such as pip) to fail.

edit: see now that you've done that, thanks! supakeen/pinnwand#93

@mweinelt
Copy link
Member Author

mweinelt commented Aug 6, 2020

Upstream issue at supakeen/pinnwand#93. Talked to the maintainer directly about this, therefore the issue is rather brief.

@mweinelt mweinelt force-pushed the pinnwand-module branch 2 times, most recently from 89cd67a to beb2ed9 Compare August 6, 2020 13:19
@mweinelt
Copy link
Member Author

mweinelt commented Aug 6, 2020

Packaging issue resolved with 1.2.1.

@mweinelt
Copy link
Member Author

mweinelt commented Aug 7, 2020

@GrahamcOfBorg test pinnwand

@mweinelt mweinelt merged commit f1efdd2 into NixOS:master Aug 14, 2020
@mweinelt mweinelt deleted the pinnwand-module branch August 14, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse requested changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mweinelt @FRidh @jonringer @aanderse