Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

josm: 16239 -> 16538 #89443

Closed
wants to merge 1 commit into from
Closed

josm: 16239 -> 16538 #89443

wants to merge 1 commit into from

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jun 3, 2020

Motivation for this change

Changelog (2020-06-02: Stable release 16538)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir sikmir requested a review from rycee June 3, 2020 21:02
rycee pushed a commit that referenced this pull request Jun 4, 2020
@sikmir @rycee
josm: 16239 -> 16538
cda41cf 
PR #89443
@rycee
Copy link
Member

rycee commented Jun 4, 2020

Thanks! Works well for me. Rebased to master in cda41cf.

@rycee rycee closed this Jun 4, 2020
@sikmir sikmir deleted the josm branch June 4, 2020 17:07
rycee pushed a commit to rycee/nixpkgs that referenced this pull request Dec 25, 2020
@sikmir @rycee
josm: 16239 -> 16538
a6f817f 
PR NixOS#89443

(cherry picked from commit cda41cf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sikmir @rycee