[WebSocket] Test header + close frame in same packet #23938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 3, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2228252
branch
from
43d8062
to
bd76d07
Compare
Modify the existing web platform test opening-handshake/005.html to send the response header and the close frame in the same packet. This verifies that Chrome passes the close data to JavaScript correctly in this case. This increases the coverage of the existing test, so there's no need to retain the old behaviour. Also remove the timeout expectations for this test, and make sure it doesn't timeout on failure. Closed: 1090210 Change-Id: I327c55d1517615511d6d71e1b464d5d3dc03b502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228252 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#775124}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2228252
branch
from
bd76d07
to
1962a64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the existing web platform test opening-handshake/005.html to send
the response header and the close frame in the same packet. This
verifies that Chrome passes the close data to JavaScript correctly in
this case.
This increases the coverage of the existing test, so there's no need to
retain the old behaviour.
Also remove the timeout expectations for this test, and make sure it
doesn't timeout on failure.
Closed: 1090210
Change-Id: I327c55d1517615511d6d71e1b464d5d3dc03b502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228252
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775124}