Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only up to 10 waveforms are loaded from a saved scope session #108

Closed
miek opened this issue Jun 2, 2020 · 1 comment · Fixed by #109
Closed

Only up to 10 waveforms are loaded from a saved scope session #108

miek opened this issue Jun 2, 2020 · 1 comment · Fixed by #109
Labels
bug Something isn't working

Comments

@miek
Copy link
Collaborator

miek commented Jun 2, 2020

It looks like the HistoryWindow's max waveforms is not changed from the default of 10 before replaying history on load, so any extra waveforms get dropped.
@azonenberg azonenberg added the bug Something isn't working label Jun 2, 2020
@azonenberg
Copy link
Collaborator

Correct. While we don't explicitly store the number of waveforms in the save file, the number of child nodes under the "waveforms:" node in the scope_metadata.yml file is sufficient for loading.

The logic that loads the waveforms should call HistoryWindow::SetMaxWaveforms() appropriately before actually adding the saved waveforms to the history.

@miek miek mentioned this issue Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OscilloscopeWindow: set max waveform count before loading waveforms
2 participants
@miek @azonenberg