Move where we set the root forced background-color #23953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 3, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2227809
branch
6 times, most recently
from
f1dcb50
to
159d2d8
Compare
We are currently setting the root background-color in forced colors mode inside the UA stylesheet. Instead, set the forced background-color directly at the viewport level (similar to dark mode). This is based on feedback from https://chromium-review.googlesource.com/c/chromium/src/+/2211124. Bug: 970285 Change-Id: I3b3280ab7816b40833e87f92fe6147d5882bc039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227809 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#776134}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2227809
branch
from
159d2d8
to
64dad61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently setting the root background-color in forced colors
mode inside the UA stylesheet. Instead, set the forced background-color
directly at the viewport level (similar to dark mode).
This is based on feedback from
https://chromium-review.googlesource.com/c/chromium/src/+/2211124.
Bug: 970285
Change-Id: I3b3280ab7816b40833e87f92fe6147d5882bc039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227809
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776134}