New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nextcloud19: init at 19.0.0 #89427
nextcloud19: init at 19.0.0 #89427
Conversation
The wording of the warnings looks alright. Though I will not test as I am not using Nextcloud in the end. |
@Ma27 When I to access a file after the upgrade a get an error:
Running |
That's interesting. I experienced a similar behavior, but (wrongly) assumed that I screwed up my initial upgrade attempt. In my case, Nextcloud reported that Before merging this, we should at least find the cause for issue. |
We've also been observing weird issues with nextcloud where restarting phpfpm-nextcloud helps. For now, I've added the configured nextcloud package and some php stuff as a |
@ajs124 I was also thinking if adding |
Sounds reasonable. I'd like to investigate the why before that though :) |
I managed to reproduce the issue in a minimal NixOS container using the configs from I assume that most of the people hosting Nextcloud somewhere else are probably restarting these services anyways and didn't notice this. |
Rebased the patches onto latest master to resolve the merge-conflict in the release-notes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works with the updated MR.
Rebased onto master to resolve the merge-conflict. Anything else tbd or is this mergeable now? |
Enhance the heuristics to make sure that a user doesn't accidentally upgrade across two major versions of Nextcloud (e.g. from v17 to v19). The original idea/discussion has been documented in the nixpkgs manual[1]. This includes the following changes: * `nextcloud19` will be selected automatically when having a stateVersion greater or equal than 20.09. For existing setups, the package has to be selected manually to avoid accidental upgrades. * When using `nextcloud18` or older, a warning will be thrown which recommends upgrading to `nextcloud19`. * Added a brief paragraph about `nextcloud19` in the NixOS 19.09 release notes. * Restart `phpfpm` if the Nextcloud-package (`cfg.package`) changes[2]. [1] https://nixos.org/nixos/manual/index.html#module-services-nextcloud-maintainer-info [2] NixOS#89427 (comment)
Thanks! |
Ported the addition of The module changes are targeted for 20.09 only. |
Motivation for this change
https://nextcloud.com/blog/nextcloud-hub-brings-productivity-to-home-office/
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)