Update interfaces/cookie-store.idl #23957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This introduces a syntax error (missing semicolon) and will need a spec fix. |
autofoolip
force-pushed
the
reffy-reports/cookie-store
branch
from
222dd2d
to
2506679
Compare
foolip
requested changes
Jun 10, 2020
interfaces/cookie-store.idl
Outdated
| DOMTimeStamp? expires; | ||
| boolean secure; | ||
| CookieSameSite sameSite; | ||
| } |
There was a problem hiding this comment.
Tests are failing because of the missing semicolon here.
foolip
added a commit
to foolip/cookie-store
that referenced
this pull request
Jun 10, 2020
|
I've sent WICG/cookie-store#145 to fix the problem. |
inexorabletash
pushed a commit
to WICG/cookie-store
that referenced
this pull request
Jun 10, 2020
autofoolip
force-pushed
the
reffy-reports/cookie-store
branch
from
2506679
to
4e0837e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by a bot.
Before merging, please check that any tests that depend on the updated IDL files still work.
If additional changes are needed, please manually create another PR based on this one.
See the README for how the IDL files in this directory are used.
Source: https://github.com/tidoust/reffy-reports/blob/3ef9f83/ed/idl/cookie-store.idl
Build: https://travis-ci.org/tidoust/reffy-reports/builds/696958118