Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed jetbrains clion clangd binary #89394

Merged
merged 1 commit into from Jun 3, 2020
Merged

Fixed jetbrains clion clangd binary #89394

merged 1 commit into from Jun 3, 2020

Conversation

uael
Copy link
Contributor

@uael uael commented Jun 3, 2020

Motivation for this change

Clion bundled clangd binary was unable to start

Things done

added zlib path to rpath in the clion bundled clangd binary

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@uael
jetbrains: update
3b605ea 
fixed missing zlib path to rpath in the clion bundled clangd binary
@uael uael requested a review from edwtjo as a code owner June 3, 2020 09:43
@ofborg ofborg bot requested a review from Mic92 June 3, 2020 09:51
@Mic92 Mic92 merged commit b68c2de into NixOS:master Jun 3, 2020
@Mic92
Copy link
Member

Mic92 commented Jun 3, 2020

Does this need a backport?

@uael
Copy link
Contributor Author

uael commented Jun 3, 2020

Yes it was also break into 20.03, do you want me to do it ?

@Mic92
Copy link
Member

Mic92 commented Jun 3, 2020

done in ede1184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeltaEvo DeltaEvo DeltaEvo approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uael @Mic92 @DeltaEvo @Janik-Haag