[EventTiming] Allow spurious inputs when looseCount is true #23925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 2, 2020
This CL is a tentative fix for some flaky tests. An assert_equals to 0 is sometimes failing, presumably because the test itself may cause some inputs to occur. Hence, we only check that eventCounts is 0 when the |looseCount| variable is set to false. Bug: 1074048 Change-Id: I989ccdb7cb469ff24132bf17a3da9a43264ae6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225293 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#774650}
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2225293
branch
from
d9049aa
to
5f8150f
Compare
|
@Hexcles could you admin merge? crossiframe test is a known flake :( sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL is a tentative fix for some flaky tests. An assert_equals to 0
is sometimes failing, presumably because the test itself may cause some
inputs to occur. Hence, we only check that eventCounts is 0 when the
|looseCount| variable is set to false.
Bug: 1074048
Change-Id: I989ccdb7cb469ff24132bf17a3da9a43264ae6ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225293
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774650}