Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2.pkgs.flask-autoindex: fix build #89397

Merged
merged 1 commit into from Jun 3, 2020
Merged

python2.pkgs.flask-autoindex: fix build #89397

merged 1 commit into from Jun 3, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented Jun 3, 2020 •
edited

Motivation for this change

pathlib is now required, which is part of the standard library in python
3.4+ but not in python 2.7. Broken by
ec12a5f

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau marked this pull request as draft June 3, 2020 11:19
@timokau
python2.pkgs.flask-autoindex: fix build
caf2c1b 
pathlib is now required, which is part of the standard library in python
3.4+ but not in python 2.7. Broken by
ec12a5f
@timokau timokau force-pushed the flask-autoindex-py2-unbreak branch from a99d970 to caf2c1b Compare June 3, 2020 11:21
@timokau
Copy link
Member Author

timokau commented Jun 3, 2020

@GrahamcOfBorg build python2.pkgs.flask-autoindex python3.pkgs.flask-autoindex

@timokau timokau marked this pull request as ready for review June 3, 2020 11:21
@timokau timokau merged commit 3f3b93b into NixOS:master Jun 3, 2020
@timokau timokau deleted the flask-autoindex-py2-unbreak branch June 3, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau