Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: b759127127d8
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: a448d9156b54
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jun 3, 2020

  1. nixos: Allow empty hostnames again 

    This fixes a regression from 993baa5 which requires
networking.hostName to be a valid DNS label [0].
Unfortunately we missed the fact that the hostnames may also be empty,
if the user wants to obtain it from a DHCP server. This is even required
by a few modules/images (e.g. Amazon EC2, Azure, and Google Compute).

[0]: #76542 (comment)
    @primeos
    primeos committed Jun 3, 2020
    Copy the full SHA
    a6afdbb View commit details
    Browse the repository at this point in the history

  2. Merge pull request #89407 from primeos/empty-hostname-fix 

    nixos: Allow empty hostnames again
    @primeos
    primeos committed Jun 3, 2020
    Copy the full SHA
    a448d91 View commit details
    Browse the repository at this point in the history