Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factorio{,-headless}-experimental: 0.18.26 -> 0.18.29 #89404

Merged
merged 1 commit into from Jun 3, 2020

Conversation

priegger
Copy link
Contributor

@priegger priegger commented Jun 3, 2020

Motivation for this change

Update to the latest (as of 2020-06-03) factorio experimental version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Builds for me.

@NickHu NickHu merged commit e37b999 into NixOS:master Jun 3, 2020
@NickHu
Copy link
Contributor

NickHu commented Jun 3, 2020

Thanks for your contribution!

@priegger priegger deleted the fix/factorio-update branch June 4, 2020 06:50
@priegger
Copy link
Contributor Author

priegger commented Jun 4, 2020

Does it make sense to backport this change to 20.03?

I'm not sure, since currently experimental on 20.03 is still at version 0.17.x. On the other hand:

  • It's a leaf package.
  • It makes sense to have the latest version of factorio available, to be able to play on servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants