Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak haskellPackages.qtah-qt5 and related packages #89371

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Unbreak haskellPackages.qtah-qt5 and related packages #89371

merged 1 commit into from
Jun 3, 2020
+0 −7

Conversation

poscat0x04
Copy link
Contributor

@poscat0x04 poscat0x04 commented Jun 2, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@poscat0x04 poscat0x04 requested a review from cdepillabout as a code owner June 2, 2020 18:45
@ofborg ofborg bot added 6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 2, 2020
@cdepillabout
Copy link
Member

LGTM, I've tested that all these packages compile locally.

@cdepillabout cdepillabout merged commit d1862df into NixOS:haskell-updates Jun 3, 2020
@poscat0x04 poscat0x04 deleted the unbreak-qtah branch June 3, 2020 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@poscat0x04 @cdepillabout