gotools: update comments regarding gopls #89372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replaced comment was stating some properties about upstream source code that are no longer the case. The new comment mentions what's the current situation in regards to the gopls binary.
rvolosatovs
reviewed
Jun 3, 2020
| # can't load package: package golang.org/x/tools/gopls: unknown import path "golang.org/x/tools/gopls": cannot find module providing package golang.org/x/tools/gopls | ||
| # That is most probably caused by golang.org/x/tools/gopls containing a separate Go module. | ||
| # In order to fix this, we simply remove the module. | ||
| # Note that build of golang.org/x/tools/cmd/gopls provides identical binary as golang.org/x/tools/gopls. |
There was a problem hiding this comment.
I guess just removing this line and adding additional references could be enough
Co-authored-by: Roman Volosatovs <rvolosatovs@users.noreply.github.com>
doronbehar
approved these changes
Sep 11, 2020
|
Damn! Github is drunk:
And the PR is still open... |
|
Oh it's all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update documentation of the gotools derivation to inform users that were relying this derivation to get the gopls binary where to get it now.
Closes #88716
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)NOTE: Given the changes are only documentation, I did not bother the derivation result is misbehaving.