Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic test for id and style attributes on MathML elements #23936

Merged
merged 1 commit into from Jun 3, 2020

Conversation

fred-wang
Copy link
Contributor

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

Copy link
Contributor

@rwlbuis rwlbuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Could the file name be more descriptive though?

@fred-wang fred-wang merged commit e8a0852 into master Jun 3, 2020
@fred-wang fred-wang deleted the mathml-dynamic-style-id branch June 3, 2020 08:54
@fred-wang
Copy link
Contributor Author

LGTM.
Could the file name be more descriptive though?

Sorry I missed this comment. There was already a test dynamic-1 for class, so I thought it made sense to do a same for id and style here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants