Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitcoin: 0.19.1 -> 0.20.0 #89415

Merged
merged 1 commit into from Jun 17, 2020
Merged

bitcoin: 0.19.1 -> 0.20.0 #89415

merged 1 commit into from Jun 17, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jun 3, 2020

Motivation for this change
  • bitcoin: 0.19.1 -> 0.20.0 - https://bitcoincore.org/en/releases/0.20.0/
  • drop openssl from buildInputs as it is no longer used by the project
  • drop rapidcheck from check checkInputs as it is no longer used by the project
  • reformat with nixpkgs-fmt
  • add meta.downloadPage and meta.changelog
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

"https://bitcoincore.org/bin/bitcoin-core-${version}/bitcoin-${version}.tar.gz"
"https://bitcoin.org/bin/bitcoin-core-${version}/bitcoin-${version}.tar.gz"
];
sha256 = "ec5a2358ee868d845115dc4fc3ed631ff063c57d5e0a713562d083c5c45efb28";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the "ec5a2358ee868d845115dc4fc3ed631ff063c57d5e0a713562d083c5c45efb28" hash is properly signed in https://bitcoincore.org/bin/bitcoin-core-0.20.0/SHA256SUMS.asc

- drop openssl from buildInputs as it is no longer used by the project
- drop rapidcheck from check checkInputs as it is no longer used by the project
- reformat with nixpkgs-fmt
- add meta.downloadPage and meta.changelog
Copy link
Contributor

@roconnor roconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built and executed the resulting programs.

@roconnor
Copy link
Contributor

roconnor commented Jun 9, 2020

After this is done it may be worth investigating if utillinux ought to be in nativeBuildInputs instead or if not, document why not (unless it is obvious to everyone but me).

@emmanuelrosa
Copy link
Contributor

It's working great for me :)

I built the package, but I only use bitcoind, so I have nothing to report about the GUI (QT) wallet. I'm running bitcoind with an unchanged configuration on NixOS, and it's working just fine.

Copy link
Contributor

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Lassulus Lassulus merged commit 02c64a4 into NixOS:master Jun 17, 2020
@prusnak prusnak deleted the bitcoin branch June 17, 2020 16:53
emmanuelrosa added a commit to emmanuelrosa/nur-packages that referenced this pull request Jun 27, 2020
This is a copy of PR NixOS/nixpkgs#89415

I'm waiting for it to be merged upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants