New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitcoin: 0.19.1 -> 0.20.0 #89415
bitcoin: 0.19.1 -> 0.20.0 #89415
Conversation
"https://bitcoincore.org/bin/bitcoin-core-${version}/bitcoin-${version}.tar.gz" | ||
"https://bitcoin.org/bin/bitcoin-core-${version}/bitcoin-${version}.tar.gz" | ||
]; | ||
sha256 = "ec5a2358ee868d845115dc4fc3ed631ff063c57d5e0a713562d083c5c45efb28"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified the "ec5a2358ee868d845115dc4fc3ed631ff063c57d5e0a713562d083c5c45efb28" hash is properly signed in https://bitcoincore.org/bin/bitcoin-core-0.20.0/SHA256SUMS.asc
- drop openssl from buildInputs as it is no longer used by the project - drop rapidcheck from check checkInputs as it is no longer used by the project - reformat with nixpkgs-fmt - add meta.downloadPage and meta.changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built and executed the resulting programs.
After this is done it may be worth investigating if |
It's working great for me :) I built the package, but I only use bitcoind, so I have nothing to report about the GUI (QT) wallet. I'm running bitcoind with an unchanged configuration on NixOS, and it's working just fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
This is a copy of PR NixOS/nixpkgs#89415 I'm waiting for it to be merged upstream.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)