Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] gitlab: 12.8.10 -> 12.10.9 #89435

Merged
merged 7 commits into from Jun 4, 2020
Merged

[20.03] gitlab: 12.8.10 -> 12.10.9 #89435

merged 7 commits into from Jun 4, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jun 3, 2020

Motivation for this change

Backport of #85293 and #89434 (due to https://about.gitlab.com/releases/2020/06/03/critical-security-release-13-0-4-released) for 20.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Milan Pässler and others added 7 commits June 3, 2020 21:32
@flokli flokli requested review from talyz, globin and a user June 3, 2020 19:40
@flokli
Copy link
Contributor Author

flokli commented Jun 3, 2020

@GrahamcOfBorg test gitlab

@ofborg ofborg bot requested review from fpletz, krav and ehmry June 3, 2020 19:47
@flokli flokli mentioned this pull request Jun 3, 2020
Closed
10 tasks
@flokli flokli merged commit 58f884c into NixOS:release-20.03 Jun 4, 2020
@flokli flokli deleted the 20.03/gitlab-12.10.9 branch June 4, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz Awaiting requested review from talyz

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

@krav krav Awaiting requested review from krav

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @globin