[Gecko Bug 1599160] Fix a racy constructable stylesheets test. #23951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is using async_test, while the others are using promise_test,
which are not synchronized with each other.
This test loads a element with the import url stylesheet, which
sets the
color
property. Color is inherited, so it can affect theshadow descendants of the trees in the other tests.
Only the following test checks the computed value of the color property,
so in practice the race doesn't happen right now because the url is
never cached.
But with the stylesheet caching improvements, if you hit the cache for
the link, it is fast enough in a way in which you might be running the
following test after the link has loaded, but before the load event
has been dispatched.
Use promise_test to properly synchronize between this test and the
following ones, to avoid flaky failures with cross-document stylesheet
caching.
Differential Revision: https://phabricator.services.mozilla.com/D78052
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1599160
gecko-commit: 79c2788498a8a636a7e64d899cbff590f2304cd0
gecko-integration-branch: autoland
gecko-reviewers: nordzilla