Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependency for cookiecutter #89412

Closed
wants to merge 1 commit into from

Conversation

EmilioPeJu
Copy link
Contributor

@EmilioPeJu EmilioPeJu commented Jun 3, 2020

Motivation for this change

Cookiecutter fails to be built due to a missing dependency, I'm not sure why it built at some point (possibly the PyPI package was replaced)

Things done
  • Add missing dependency: python-slugify
  • Test executable after building using Nix in Arch Linux
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • [x ] other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@EmilioPeJu
Copy link
Contributor Author

EmilioPeJu commented Jun 3, 2020

Sorry, I realized it is duplicated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants