Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add standalone url field to fx2 setup.py #4

Closed
wants to merge 1 commit into from
Closed

Add standalone url field to fx2 setup.py #4

wants to merge 1 commit into from

Conversation

artizirk
Copy link

@artizirk artizirk commented Jun 2, 2020

This should add a visible homepage link to pypi sidebar 1 on next
release upload.

@artizirk
Add standalone url field to fx2 setup.py
733f1a3 
This should add a visible homepage link to pypi sidebar [1] on next
release upload.

[1]:https://pypi.org/project/fx2/
@whitequark
Copy link
Owner

whitequark commented Jun 2, 2020 •
edited

Huh. Why don't these links already show up in sidebar?
Screenshot_20200602_204349

@artizirk
Copy link
Author

artizirk commented Jun 3, 2020

It could be some edge case with url metadata handling, twine also uses project_urls field and those show up fine. I will try to dig deeper to figure out whats going on.

@artizirk
Copy link
Author

artizirk commented Jun 3, 2020

So, I did some testing with testpypi and it looks like both, with and without the url field show all three project_urls links.

Also python3 setup.py check does complain about missing url meta-data

$ python3 setup.py check
running check
warning: Check: missing required meta-data: url

Package upload to testpypi was done with twine 2.0.0. I don't know it that has something to do with missing links.

Screenshot_2020-06-03 fx2

Screenshot_2020-06-03 fx2(1)

@whitequark
Copy link
Owner

Okay so the only thing I have to do here is to upload the package again with twine, right?

@artizirk
Copy link
Author

artizirk commented Jun 5, 2020

I think so yes.

@whitequark
Copy link
Owner

I've uploaded with twine but there are still no project links anywhere.

@whitequark
Copy link
Owner

The links are fixed now: https://pypi.org/project/fx2/

@whitequark whitequark closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@artizirk @whitequark