Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.owl: unbreak by reversing previous edits #86425

Merged
merged 1 commit into from May 6, 2020
Merged

ocamlPackages.owl: unbreak by reversing previous edits #86425

merged 1 commit into from May 6, 2020

Conversation

bcdarwin
Copy link
Member

cc @vbgl @matthewbauer

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin
Copy link
Member Author

bcdarwin commented May 1, 2020

@GrahamcOfBorg build ocamlPackages.owl

1 similar comment
@vbgl
Copy link
Contributor

vbgl commented May 1, 2020 •
edited

@GrahamcOfBorg build ocamlPackages.owl

vbgl
vbgl approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know enough about BLAS to comment about openblasCompat, but at least, this builds and runs fine…

@vbgl vbgl merged commit d737f31 into NixOS:master May 6, 2020
@bcdarwin bcdarwin deleted the unbreak-owl branch May 6, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ocamlPackages.owl is broken
2 participants
@bcdarwin @vbgl