Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qimgv: 0.8.9 -> 0.9 #86428

Merged
merged 1 commit into from May 1, 2020
Merged

qimgv: 0.8.9 -> 0.9 #86428

merged 1 commit into from May 1, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented May 1, 2020

easymodo/qimgv@v0.8.9...v0.9

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I've filed easymodo/qimgv#205 to see if we can't get that single Qt 5.12-incompatible change reverted. They've added a patch that fixes this (in record time, if I might add), which will be present in the next release.

@FRidh FRidh merged commit a3f27a2 into NixOS:master May 1, 2020
@cole-h cole-h deleted the qimgv branch May 3, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants