Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvorbis: fix 404'ing patch #86429

Merged
merged 1 commit into from May 1, 2020
Merged

libvorbis: fix 404'ing patch #86429

merged 1 commit into from May 1, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented May 1, 2020

Also use full commit for the other patch, just in case there's ever a
collision, as unlikely as that may be.

Motivation for this change

Thanks to Kyndig on IRC, again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I'll open backport PRs after this is merged. @veprbl, since you did that last time for the ninja 404, should I backport to 19.03 and 19.09 as well? (20.03 is a given)

veprbl
veprbl reviewed May 1, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

hash mismatch in fixed-output derivation '/nix/store/w00h096swm34ankjl81dxf83lz25q9bq-CVE-2017-14160+CVE-2018-10393.patch':
  wanted: sha256:0v21p59cb3z77ch1v6q5dcrd733h91f3m8ifnd7kkkr8gzn17d5x
  got:    sha256:18k4vp0nmrxxpis641ylnw6dgwxrymh5bf74njr6v8dizmmz1bkj

@cole-h
libvorbis: fix 404'ing patch
f02e1c2 
Also use full commit for the other patch, just in case there's ever a
collision, as unlikely as that may be.
@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label May 1, 2020
@cole-h
Copy link
Member Author

cole-h commented May 1, 2020

Huh, I swore I checked that with ,vimtofu... Sorry, should be sorted now.

@ofborg ofborg bot requested a review from ehmry May 1, 2020 03:37
@cole-h
Copy link
Member Author

cole-h commented May 1, 2020

Darn, I was hoping this wouldn't need to go to staging...

@veprbl
Copy link
Member

veprbl commented May 1, 2020

This is no big deal

@veprbl veprbl changed the base branch from master to staging May 1, 2020 03:56
@veprbl veprbl added this to WIP in Staging via automation May 1, 2020
Staging automation moved this from WIP to Ready May 1, 2020
@FRidh FRidh merged commit 90c5032 into NixOS:staging May 1, 2020
Staging automation moved this from Ready to Done May 1, 2020
@cole-h cole-h deleted the patch-404 branch May 1, 2020 14:57
@cole-h cole-h added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cole-h @veprbl @FRidh