New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump powershell #86423
Bump powershell #86423
Conversation
Package and openssl dependency version bump and cascading changes.
017e082
to
342aa98
Compare
Hi, thanks for this. Sorry I couldn't look earlier (Might sound luddite but I don't check email regularly ... :( ) |
I reviewed: e4bb796 Instructions for a first time reviewer (such as me):
Checking the diffs in vim with whitespace removed shows that the only changes are:
I can confirm that this is fine for Linux. |
Yea, i was able to get it to work fine on Linux as well. I just want to ensure that I'm not causing a regression to darwin, which previously worked. Wish they would use a newer version of openssl by default. Would make a lot of this a lot easier |
Using a passed library and gating the deletion on non-darwin env. Presuming, (somewhat obviously) that you've tested this on Darwin. Approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see in vi
doInstallCheck
and an installCheck
added. Approved.
passes on darwin, merging :) |
@jonringer Does this qualify for a backport to 20.03? It doesn't eval there because OpenSSL is insecure. |
Don't know the backporting policy but @dasJ you can consider using unstable for powershell. |
@dasJ Unless there's a major security vulnerability, I think not issuing another major version would be wise for the release branch |
Motivation for this change
closes: #84454
enables darwin usage
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)