Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qutebrowser: 1.10.1 -> 1.11.0 #86478

Merged
merged 1 commit into from May 1, 2020
Merged

qutebrowser: 1.10.1 -> 1.11.0 #86478

merged 1 commit into from May 1, 2020

Conversation

paumr
Copy link
Contributor

@paumr paumr commented May 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from jagajaga, ebzzry and rnhmjoj May 1, 2020 14:57
@flokli
Copy link
Contributor

flokli commented May 1, 2020

@GrahamcOfBorg build qutebrowser

rnhmjoj
rnhmjoj approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Built and tested by running qutebrowser and some normal interactions.

@flokli flokli merged commit fc5cd47 into NixOS:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@jagajaga jagajaga Awaiting requested review from jagajaga

@ebzzry ebzzry Awaiting requested review from ebzzry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paumr @flokli @rnhmjoj