Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove static lifetimes from easylapin #479

Merged
merged 1 commit into from May 3, 2020
Merged

remove static lifetimes from easylapin #479

merged 1 commit into from May 3, 2020

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented May 1, 2020

Unlike amqp::Consumer lapin channels don't need to have a 'static
lifetime, the workers just need to live at least as long as the channel.

@LnL7
remove static lifetimes from easylapin
c4ab729 
Unlike amqp::Consumer lapin channels don't need to have a 'static
lifetime, the workers just need to live at least as long as the channel.
cole-h
cole-h approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@LnL7 LnL7 merged commit 45201a2 into NixOS:released May 3, 2020
@LnL7 LnL7 deleted the lapin-lifetimes branch May 3, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LnL7 @cole-h