Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p7zip: fix two CVEs and mark as insecure #86417

Merged
merged 2 commits into from May 1, 2020
Merged

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Apr 30, 2020

Motivation for this change

This fixes the two CVEs mentioned in the commit (patches taken from Debian).
Additionally, the p7zip-project is a port of 7zip. 7zip appears alive and well, but p7zip has not seen any development since 2016 and no bugfixes or even security fixes are being released.
As discussed in https://discourse.nixos.org/t/p7zip-and-possible-rces/6951, carrying an abandoned project is a risk, so I'm marking the package as unsafe.
p7zip is used by about 35 other packages, so this will lead to issues in other packages. The following is a list of other affected nix files:

  • nixos/modules/services/misc/nzbget.nix
  • nixos/modules/services/torrent/deluge.nix
  • nixos/tests/nzbget.nix
  • pkgs/applications/editors/jetbrains/common.nix
  • pkgs/applications/graphics/kcc/default.nix
  • pkgs/applications/kde/ark/default.nix
  • pkgs/applications/misc/far2l/default.nix
  • pkgs/applications/misc/lutris/chrootenv.nix
  • pkgs/applications/misc/lutris/default.nix
  • pkgs/applications/misc/multibootusb/default.nix
  • pkgs/applications/misc/playonlinux/default.nix
  • pkgs/applications/misc/sweethome3d/default.nix
  • pkgs/applications/virtualization/driver/win-qemu/default.nix
  • pkgs/applications/virtualization/driver/win-signed-gplpv-drivers/default.nix
  • pkgs/applications/virtualization/driver/win-spice/default.nix
  • pkgs/applications/virtualization/driver/win-virtio/default.nix
  • pkgs/data/fonts/marathi-cursive/default.nix
  • pkgs/data/fonts/oldsindhi/default.nix
  • pkgs/data/fonts/rounded-mgenplus/default.nix
  • pkgs/data/fonts/sarasa-gothic/default.nix
  • pkgs/development/mobile/flashtool/default.nix
  • pkgs/development/python-modules/binwalk/default.nix
  • pkgs/development/tools/flatpak-builder/default.nix
  • pkgs/games/spring/default.nix
  • pkgs/games/tdm/default.nix
  • pkgs/games/zdoom/default.nix
  • pkgs/misc/emulators/wine/winetricks.nix
  • pkgs/os-specific/linux/ply/default.nix
  • pkgs/os-specific/linux/prl-tools/default.nix
  • pkgs/servers/sabnzbd/default.nix
  • pkgs/tools/cd-dvd/unetbootin/default.nix
  • pkgs/tools/compression/dtrx/default.nix
  • pkgs/tools/filesystems/fuse-7z-ng/default.nix
  • pkgs/tools/misc/hostsblock/default.nix
  • pkgs/tools/misc/memtest86-efi/default.nix
  • pkgs/tools/misc/woeusb/default.nix
  • pkgs/tools/security/rarcrack/default.nix
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tokudan
Copy link
Contributor Author

tokudan commented Apr 30, 2020

@GrahamcOfBorg build p7zip

@jtojnar
Copy link
Contributor

jtojnar commented Apr 30, 2020

Removed from flatpak-builder in d74e044

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/p7zip-and-possible-rces/6951/4

@flokli flokli merged commit d92d0c3 into NixOS:master May 1, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/p7zip-and-possible-rces/6951/5

This was referenced May 1, 2020
@tokudan tokudan deleted the p7zip-abandoned branch May 1, 2020 13:14
@peterhoeg peterhoeg mentioned this pull request May 3, 2020
10 tasks
knownVulnerabilities = [
# p7zip is abandoned, according to this thread on its forums:
# https://sourceforge.net/p/p7zip/discussion/383043/thread/fa143cf2/#1817
"p7zip is abandoned and may not receive important security fixes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any known security vulnerabilities though right now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not as far as I'm aware.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants