Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] backport v4l2loopback and broadcom-sta fixes #86440

Merged
merged 2 commits into from May 1, 2020
Merged

[20.03] backport v4l2loopback and broadcom-sta fixes #86440

merged 2 commits into from May 1, 2020

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

linuxpackages_latest users in 20.03 are affected by linux 5.6 compatibility bugs fixed in the backported commits.

Things done

Backported #84736 and #84929.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer @duckfullstop @rasendubi @worldofpeace

teto and others added 2 commits May 1, 2020 08:44
@teto @elohmeier
broadcom_sta: fix build on 5.6
129e603 
(cherry picked from commit 8ce6508)
Reason: fixes issue for linuxPackages_latest users in 20.03, see NixOS#84736
@Trundle @elohmeier
v4l2loopback: 0.12.3 -> 0.12.4
cf9f88b 
(cherry picked from commit 9ddfde8)
Reason: fixes issue for linuxPackages_latest users in 20.03, see NixOS#84929
@ofborg ofborg bot requested review from domenkozar and Phreedom May 1, 2020 06:58
@elohmeier elohmeier added the 8.has: port to stable A PR already has a backport to the stable release. label May 1, 2020
mmilata
mmilata approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that v4l2loopback failed to build before and now it builds and loads fine!

Btw there's also #86209 which should work with 5.7 once it comes out.

@flokli flokli merged commit 53a1ae1 into NixOS:release-20.03 May 1, 2020
@elohmeier elohmeier deleted the 20.03-kmod-backports branch May 1, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@jonringer jonringer Awaiting requested review from jonringer

@rasendubi rasendubi Awaiting requested review from rasendubi

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@domenkozar domenkozar Awaiting requested review from domenkozar

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@elohmeier @mmilata @flokli @teto @Trundle