Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domoticz: init at 2020.2 #86404

Merged
merged 5 commits into from Oct 11, 2020
Merged

domoticz: init at 2020.2 #86404

merged 5 commits into from Oct 11, 2020

Conversation

nuxeh
Copy link
Contributor

@nuxeh nuxeh commented Apr 30, 2020

Motivation for this change

Add Domoticz home automation server.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nuxeh nuxeh force-pushed the nuxeh/domoticz-init-2020.2 branch from 251fe68 to ec6ead1 Compare April 30, 2020 19:07
@nuxeh nuxeh force-pushed the nuxeh/domoticz-init-2020.2 branch from ec6ead1 to e7eb689 Compare April 30, 2020 19:21
@nuxeh
Copy link
Contributor Author

nuxeh commented May 2, 2020 •
edited

Currently it seems quite difficult to emit binaries to $out/bin etc, since at runtime the binary depends on static files existing in the same directory the binary is run from, and I can't currently find a way to configure it to find the static files it needs, packaging them in $out/share/domoticz for example.

@nuxeh nuxeh force-pushed the nuxeh/domoticz-init-2020.2 branch 4 times, most recently from ff953cd to 8c712c0 Compare May 2, 2020 21:20
@nuxeh nuxeh marked this pull request as draft May 3, 2020 00:12
@nuxeh nuxeh force-pushed the nuxeh/domoticz-init-2020.2 branch 2 times, most recently from 896a3a2 to eda2a15 Compare May 3, 2020 16:49
@nuxeh nuxeh marked this pull request as ready for review May 3, 2020 17:03
@nuxeh nuxeh force-pushed the nuxeh/domoticz-init-2020.2 branch from eda2a15 to 6eb1179 Compare May 4, 2020 09:59
@nuxeh
Copy link
Contributor Author

nuxeh commented May 4, 2020

Outputs are now in $out/bin and $out/share/domoticz. I found an undocumented command line parameter allowing the binary to find its static files.

@nuxeh nuxeh force-pushed the nuxeh/domoticz-init-2020.2 branch 2 times, most recently from 3bd7690 to 704d4c8 Compare May 4, 2020 11:27
@nuxeh
Copy link
Contributor Author

nuxeh commented May 4, 2020

@ofborg eval

@nuxeh nuxeh force-pushed the nuxeh/domoticz-init-2020.2 branch from 704d4c8 to 11310e7 Compare May 4, 2020 12:24
@nuxeh nuxeh marked this pull request as draft May 4, 2020 12:53
@nuxeh
Copy link
Contributor Author

nuxeh commented May 4, 2020

Realised hashes keep changing, probably due to use of deepClone, I'll rework this.

@nuxeh nuxeh force-pushed the nuxeh/domoticz-init-2020.2 branch from 11310e7 to c768364 Compare May 17, 2020 13:21
@nuxeh nuxeh marked this pull request as ready for review May 17, 2020 13:50
@nuxeh
Copy link
Contributor Author

nuxeh commented Jul 9, 2020

@ofborg eval

@ryantm
Copy link
Member

ryantm commented Oct 10, 2020

@nuxeh I'm going to convert this to a draft, since there is no indication you are done. Feel free to move it out of draft when it is ready.

@ryantm ryantm marked this pull request as draft October 10, 2020 03:29
@nuxeh nuxeh marked this pull request as ready for review October 10, 2020 08:40
@nuxeh
Copy link
Contributor Author

nuxeh commented Oct 10, 2020 •
edited

@ryantm it's ready, thoroughly tested, and has been waiting 4 months for review

ryantm
ryantm requested changes Oct 10, 2020
View reviewed changes
nixos/modules/services/misc/domoticz.nix Outdated Show resolved Hide resolved
pkgs/servers/domoticz/default.nix Outdated Show resolved Hide resolved
@ryantm
Copy link
Member

ryantm commented Oct 10, 2020

Result of nixpkgs-review pr 86404 1

1 package blacklisted:
- tests.nixos-functions.nixos-test
1 package built:
- domoticz

@ryantm
Copy link
Member

ryantm commented Oct 10, 2020

Used nixos-shell to test that the service starts up.

@nuxeh
Copy link
Contributor Author

nuxeh commented Oct 11, 2020

Have tested with the new dynamic user changes, and runs as expected.

@ryantm ryantm merged commit 8ebf265 into NixOS:master Oct 11, 2020
@nuxeh
Copy link
Contributor Author

nuxeh commented Oct 11, 2020

Thanks for reviewing @ryantm, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nuxeh @ryantm