Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] re2c: 1.2.1 -> 1.3 + patch #86447

Merged
merged 2 commits into from Jun 22, 2020
Merged

[20.03] re2c: 1.2.1 -> 1.3 + patch #86447

merged 2 commits into from Jun 22, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented May 1, 2020

Backport of #86413.

https://github.com/skvadrik/re2c/blob/1.3/CHANGELOG

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata mmilata added 1.severity: security 8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release. labels May 1, 2020
@ofborg ofborg bot requested a review from thoughtpolice May 1, 2020 09:12
@drewrisinger
Copy link
Contributor

@GrahamcOfBorg build re2c

@drewrisinger
Copy link
Contributor

Ran with nixpkgs-review pr 86447 for ~30 mins, and was still just downloading the upstream dependencies. I think I'll approve this based on approval of #86413, just note for merger that it's not actually tested/built locally.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review for a reasonable amount of time without any failures (or marked preexisting failures as broken). Ran for 30 mins, but didn't actually get to build anything in that time.

drewrisinger
drewrisinger approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on prior approval of #86413. Build attempted locally but took too long to produce a meaningful result. OfBorg build works though.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/148

vcunat
vcunat approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds OK. This has somehow fallen through the cracks.

@vcunat vcunat added this to Ready in Staging (stable) via automation Jun 22, 2020
@vcunat vcunat merged commit acaa673 into NixOS:staging-20.03 Jun 22, 2020
Staging (stable) automation moved this from Ready to Done Jun 22, 2020
@mmilata mmilata deleted the 20.03/re2c-1.3 branch June 22, 2020 15:08
@dotlambda dotlambda mentioned this pull request Jan 30, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@drewrisinger drewrisinger drewrisinger approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
1.severity: security 8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging (stable)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmilata @drewrisinger @nixos-discourse @vcunat