Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman: use $out instead of $bin with buildGoPackage #86445

Merged
merged 1 commit into from May 4, 2020
Merged

podman: use $out instead of $bin with buildGoPackage #86445

merged 1 commit into from May 4, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 1, 2020

This reapplies the podman changes c59c4e3#diff-25d004fa5a2ccb61035e5dd01da42798L7.

Also update the podman-wrapper which was added after #85535 was merged to staging.

cc @adisbladis @FRidh @Mic92

@adisbladis
Copy link
Member

@GrahamcOfBorg test podman

@zowoq
Copy link
Contributor Author

zowoq commented May 1, 2020

https://hydra.nixos.org/jobset/nixpkgs/trunk/jobs-tab?filter=podman

Looks like the wrapper build failure is the same.

@adisbladis
Copy link
Member

@GrahamcOfBorg build podman

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to buildGoModule would solve the problem too, right? 🙃

@zowoq
Copy link
Contributor Author

zowoq commented May 4, 2020

Switching to buildGoModule would solve the problem too, right?

This would still be necessary with buildGoModule.

@Mic92 Mic92 merged commit 320f793 into NixOS:staging-next May 4, 2020
@zowoq zowoq deleted the podman-staging branch May 4, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants