Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 12.8.9 -> 12.8.10 #86420

Merged
merged 3 commits into from May 1, 2020
Merged

gitlab: 12.8.9 -> 12.8.10 #86420

merged 3 commits into from May 1, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Apr 30, 2020

Motivation for this change

https://about.gitlab.com/releases/2020/04/30/security-release-12-10-2-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Apr 30, 2020
@flokli flokli requested review from talyz, fpletz, globin, a user and Ma27 April 30, 2020 21:18
@flokli
Copy link
Contributor Author

flokli commented Apr 30, 2020

@GrahamcOfBorg test gitlab

@flokli
gitlab: update.py: use the /refs endpoint
fc64bca 
It seems the atom feed now needs authentication. Use the /refs endpoint,
which is used for the switch branch/tag dropdown. It doesn't show all
records, but has some pagination, but works well enough for now.
@ghost
Copy link

ghost commented May 1, 2020

Why does this have two commits with the same description?

@flokli
Copy link
Contributor Author

flokli commented May 1, 2020

Why does this have two commits with the same description?

It doesn't. It's Gitaly and GitLab.

@ghost
Copy link

ghost commented May 1, 2020

Oh I see it now.

@talyz
Copy link
Contributor

talyz commented May 1, 2020

Looks good! Thanks!

@talyz talyz merged commit 998ac52 into NixOS:master May 1, 2020
This was referenced May 1, 2020
Merged
Merged
@flokli flokli deleted the gitlab-12.8.10 branch May 1, 2020 12:00
@talyz talyz added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz Awaiting requested review from talyz

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @talyz