Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] cups: 2.3.1 -> 2.3.3 #86455

Merged
merged 1 commit into from May 9, 2020
Merged

[20.03] cups: 2.3.1 -> 2.3.3 #86455

merged 1 commit into from May 9, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented May 1, 2020

Backport of #86419.

Changes: https://github.com/apple/cups/releases/tag/v2.3.3

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata mmilata added 6.topic: printing 8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release. labels May 1, 2020
@ofborg ofborg bot requested a review from matthewbauer May 1, 2020 10:25
@drewrisinger
Copy link
Contributor

@GrahamcOfBorg build cups

drewrisinger
drewrisinger approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms. Don't know how to trigger for Darwin, but that part was unchanged.
  • run nix-review for a reasonable amount of time without any failures (or marked preexisting failures as broken). Run for ~60 mins, and didn't finish downloading all the dependencies...

@drewrisinger
Copy link
Contributor

@GrahamcOfBorg build cups

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/148

@FRidh FRidh changed the base branch from staging-20.03 to release-20.03 May 9, 2020 07:42
@FRidh FRidh merged commit f354d93 into NixOS:release-20.03 May 9, 2020
@mmilata mmilata deleted the 20.03/cups-2.3.3 branch May 9, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
1.severity: security 6.topic: printing 8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmilata @drewrisinger @nixos-discourse @FRidh