Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picom: 7.5 -> 8 #86456

Merged
merged 1 commit into from May 25, 2020
Merged

picom: 7.5 -> 8 #86456

merged 1 commit into from May 25, 2020

Conversation

kraem
Copy link
Member

@kraem kraem commented May 1, 2020

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kraem kraem requested a review from Enzime May 1, 2020 10:27
@Br1ght0ne
Copy link
Member

Result of nixpkgs-review pr 86456 1

1 package built:
- picom

eadwu
eadwu approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been using this fine last few days.

@kraem
Copy link
Member Author

kraem commented May 6, 2020

Ping @Twey, can't request you as a reviewer

@domenkozar domenkozar merged commit c969647 into NixOS:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@eadwu eadwu eadwu approved these changes

@Enzime Enzime Awaiting requested review from Enzime

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kraem @Br1ght0ne @eadwu @domenkozar