Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsass: fix unpacking on ZFS Nix store with normalization=formD #86432

Closed
wants to merge 1 commit into from
Closed

libsass: fix unpacking on ZFS Nix store with normalization=formD #86432

wants to merge 1 commit into from

Conversation

ju1m
Copy link
Contributor

@ju1m ju1m commented May 1, 2020 •
edited

Motivation for this change

using a /nix/store over a ZFS dataset using normalization=formD breaks the libsass unpacking, which contains two directories whose names have the same normalization

Things done

Use tar options to exclude the colliding paths.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stale
Copy link

stale bot commented Jun 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021
@Artturin
Copy link
Member

Artturin commented Oct 5, 2021

is this still relevant?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 5, 2021
@ju1m
Copy link
Contributor Author

ju1m commented Oct 12, 2021

@Artturin, back in April 2020, normalization=formD was recommended on the ZFS page of the NixOS wiki, but after my reporting of this problem to @grahamc, it was subsequently removed. So it's unlikely someone else will be bitten by this now.
This said, this PR makes libsass more portable, avoiding the trouble of recreating the ZFS pool to reset to the default normalization=none (indeed, normalization= is a setting only writable when creating a pool).

@SuperSandro2000
Copy link
Member

This said, this PR makes libsass more portable

If there is no real use case we can close this.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/zfs-systemd-boot/29956/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ju1m @Artturin @SuperSandro2000 @nixos-discourse @ryantm