Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p7zip: fix two CVEs #86468

Merged
merged 1 commit into from May 1, 2020
Merged

p7zip: fix two CVEs #86468

merged 1 commit into from May 1, 2020

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented May 1, 2020 •
edited

Motivation for this change

This is a backport of #86417 to the current release. I've excluded the warning about the software effectively having no developer, to avoid breaking existing setups, as there are no more publicly known vulnerabilities at this point.
Not sure what our release managers prefer (@worldofpeace @disassembler) regarding the warning?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tokudan
p7zip: fix two CVEs
de316f9 
(cherry picked from commit dd16c39)
@ofborg ofborg bot requested a review from 7c6f434c May 1, 2020 13:02
@mweinelt
Copy link
Member

mweinelt commented May 1, 2020 •
edited

Built with nixpkgs-review, LGTM.

1 package failed to build:

flashtool
builder for '/nix/store/sygvfdclh3hgi51ayv2lrsinj87ywpng-flashtool-0.9.14.0-linux.tar.7z.drv' failed with exit code 1; last 10 log lines:
  ***
  Unfortunately, we cannot download file flashtool-0.9.14.0-linux.tar.7z automatically.
  Please go to http://dfiles.eu/files/n8c1c3pgc to download it yourself, and add it to the Nix store
  using either
    nix-store --add-fixed sha256 flashtool-0.9.14.0-linux.tar.7z
  or
    nix-prefetch-url --type sha256 file:///path/to/flashtool-0.9.14.0-linux.tar.7z



cannot build derivation '/nix/store/asngzqlmvsni74z9ms0bcbbv8asqask4-flashtool-0.9.14.0.drv': 1 dependencies couldn't be built

cannot build derivation '/nix/store/n4gqsih58rhk4i0kc982vl3025vbf1sh-env.drv': 1 dependencies couldn't be built

14 packages built:

  • ark
  • dtrx
  • far2l
  • fuse-7z-ng
  • higan
  • hostsblock
  • jetbrains.clion
  • jetbrains.datagrip
  • jetbrains.goland
  • jetbrains.idea-community
  • jetbrains.idea-ultimate
  • kcc
  • sweethome3d.furniture-editor
  • win-signed-gplpv-drivers

@andir andir merged commit cff5440 into NixOS:release-20.03 May 1, 2020
@andir
Copy link
Member

andir commented May 1, 2020

I think this is the correct way forward for a release. If we receive notice of enough unfixed/unfixable issues we might consider marking it as insecure but for now just fixing those we know about seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tokudan @mweinelt @andir