Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bront_fonts: init at 2015-06-28 #86450

Merged
merged 2 commits into from Oct 18, 2021
Merged

bront_fonts: init at 2015-06-28 #86450

merged 2 commits into from Oct 18, 2021

Conversation

GRBurst
Copy link
Contributor

@GRBurst GRBurst commented May 1, 2020

Signed-off-by: GRBurst GRBurst@protonmail.com

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ryantm
ryantm requested changes Oct 10, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update based on suggestion.

@SuperSandro2000
Copy link
Member

@GRBurst ping

@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 23, 2021
@GRBurst
Copy link
Contributor Author

GRBurst commented Sep 23, 2021

Sry all, got totally off my radar 🙈
Thanks for the suggestion @Lassulus and @ryantm

@GRBurst
bront_fonts: init at 2015-06-28
faf3077 
Signed-off-by: GRBurst <GRBurst@protonmail.com>
@GRBurst @SuperSandro2000
Prefix version with unstable
29ea4c3 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000 SuperSandro2000 merged commit a327285 into NixOS:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus left review comments

@ryantm ryantm Awaiting requested review from ryantm

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GRBurst @SuperSandro2000 @ryantm @Lassulus