Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kops: fix hash #86457

Merged
merged 1 commit into from May 1, 2020
Merged

kops: fix hash #86457

merged 1 commit into from May 1, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented May 1, 2020

As seen on https://hydra.nixos.org/build/118009308

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -58,6 +58,6 @@ in rec {

kops_1_16 = mkKops {
version = "1.16.1";
sha256 = "08vy57ln0qar961sf9vbrh29f04qj5siqsfim1kqwvj5xrvwa39i";
sha256 = "04ji1703z6b3rd4wmccah68api0jj2bndzkgdzqi855gccqbmi5g";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused. Ofborg disagrees:

  wanted: sha256:04ji1703z6b3rd4wmccah68api0jj2bndzkgdzqi855gccqbmi5g
  got:    sha256:08vy57ln0qar961sf9vbrh29f04qj5siqsfim1kqwvj5xrvwa39i

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds locally though?

Copy link
Contributor Author

@flokli flokli May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did locally replace with all-zeros and TOFU-copied in the hash I got, and successfully built.

Seems this is also what hydra sees, so I'd assume ofborg is wrong here.

Can you checkout locally too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It built locally as I said.

@flokli flokli merged commit a075ecd into NixOS:master May 1, 2020
@flokli flokli deleted the kops-1.16.1 branch May 1, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants