terminator: 1.91 -> 1.92 #86462
Merged
terminator: 1.91 -> 1.92 #86462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SFrijters
requested review from
bjornfor,
OmnipotentEntity,
jtojnar and
borisbabic
bjornfor
approved these changes
May 1, 2020
jtojnar
reviewed
May 1, 2020
| src = fetchFromGitHub { | ||
| owner = "gnome-terminator"; | ||
| repo = "terminator"; | ||
| rev = "bb24273eb40dc5eac97de74064488701fa40a743"; |
There was a problem hiding this comment.
Suggested change
| rev = "bb24273eb40dc5eac97de74064488701fa40a743"; | |
| rev = "v${version}"; |
There was a problem hiding this comment.
Good point! The PR was already merged though - should I open a new one for the fixup, or reopen this one?
There was a problem hiding this comment.
Ugh, missed this was merged. Since merged PRs cannot be reopened, I pushed the fixes in 64c09a3.
veprbl
added
the
9.needs: port to stable
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The terminator project has been picked up by a new team and they have started to release new versions. This latest version also makes terminator compatible with python3.
Attempts to close #86415 .
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Open issue: I have to strip out a check for dbus-python to allow installation to proceed. If I look at the patched/wrapped result dbus-python is correctly added, so for me it didn't seem to cause any problems. A similar thing seems to have been done in 3a1033c .