Staging next #86442
Merged
Staging next #86442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the distribution they are located in a separate directory from the others and the standard installation doesn't process them.
I've since convinced upstream to not use such vars for the build platform during cross. Finally!
Bumping binutils to 2.32 broke coreutils for unknown reasons[1]. Upon further investigation we found that there was some issue with mknod inside a chroot[2][3], which setting ac_cv_func_lchmod to "no" _somehow_ fixes. We apply this fix and hope to never have to debug this again. Thanks to @flokli and @LnL7 who helped me chase after this and @pbogdan who found the fix in the fedora build. [1]: #85951 [2]: #85951 (comment) [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1811038
- I've removed the stack of patch linked to https://sourceware.org/bugzilla/show_bug.cgi?id=23428 . The associated issue says it is closed and targeted for 2.32. - I've ugraded the "no_plugin" patch. The logic changed in https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=41f37a6fb71f2a3de388108f5cdfca9cbe6e9d51 and I tried to keep the same logic by disabling everything. It closes #78197
libcbor: Fix pkgconfig being placed correctly
opencv4: 4.1.2 -> 4.3.0
binutils: 2.31.1 -> 2.34
|
please fix conflicts |
ofborg
bot
added
6.topic: golang
6.topic: nixos
6.topic: printing
6.topic: python
6.topic: stdenv
|
Made two reverts of master changes to avoid merge conflicts. |
|
Is this ready to be merged? |
|
Hydra shows that 37k jobs are remaining, so I'd say it's too early. |
|
@vcunat |
|
Oh, I looked bad (missed the PR somehow; probably ignored merged ones). I'll take care of conflict resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)