Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r20.03] git: use tcl/tk from nixpkgs on darwin #86421

Merged
merged 1 commit into from May 6, 2020
Merged

[r20.03] git: use tcl/tk from nixpkgs on darwin #86421

merged 1 commit into from May 6, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 30, 2020

Motivation for this change

Backport of #81521 to stable, because the lack of git gui on macos is annoying me. Tested on macos 10.14.

Aimed at staging- due to hugeness of rebuild.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 30, 2020
@risicle
Copy link
Contributor Author

risicle commented Apr 30, 2020

@GrahamcOfBorg build gitFull

@ofborg ofborg bot requested review from the-kenny, peti, wmertens and globin April 30, 2020 21:32
@LnL7
Copy link
Member

LnL7 commented May 3, 2020

The staging-* branches for releases are generally only used during the release process, and the rebuild count isn't that bad. This can go straight to release-20.03

@risicle risicle force-pushed the ris-git-tcltk-darwin-r20.03 branch from 7ddd7e4 to f98c32e Compare May 3, 2020 12:05
@risicle risicle changed the base branch from staging-20.03 to release-20.03 May 3, 2020 12:06
@risicle
Copy link
Contributor Author

risicle commented May 3, 2020 •
edited

Fair enough - rebased.

@GrahamcOfBorg build gitFull

(oh wait that doesn't do darwin anyway :( )

@cdepillabout
Copy link
Member

cdepillabout commented May 3, 2020 •
edited

@GrahamcOfBorg build gitFull

(@risicle This should hopefully hit darwin for you)

@wmertens
Copy link
Contributor

wmertens commented May 6, 2020

👍

@wmertens wmertens merged commit 788f02c into NixOS:release-20.03 May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

@peti peti Awaiting requested review from peti

@wmertens wmertens Awaiting requested review from wmertens

@globin globin Awaiting requested review from globin

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@risicle @LnL7 @cdepillabout @wmertens @thefloweringash