Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flakes: Only check apps for the current system #3726

Closed
wants to merge 1 commit into from

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Jun 21, 2020

When running nix flake check against a flake containing apps for unsupported systems, it will fail with an error like this:

a 'aarch64-linux' with features {} is required to build '/nix/store/9wpnn4am8jc1vyp40ks6hizk3m53d4r0-hello.drv', but I am a 'x86_64-linux' with features {benchmark, big-parallel, kvm, nixos-test}

example flake gist

This change will only check apps for the current system as done by the checks output.

CC @edolstra

@B4dM4n B4dM4n mentioned this pull request Jun 21, 2020
edolstra added a commit that referenced this pull request Jun 22, 2020
This was inconsistent since we're not building 'packages' or
'defaultPackage' either.

Closes #3726.
@edolstra
Copy link
Member

I realized that it's actually inconsistent to have nix flake check build apps at all since it doesn't build packages either. So I've removed building of apps in 334e26b. To test an app, it should be included in checks.${system}.

@edolstra edolstra closed this Jun 22, 2020
@B4dM4n B4dM4n deleted the flakes-app-check-system branch June 22, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants