add xps 13 (9343) #174
Merged
add xps 13 (9343) #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
friendly ping @Mic92 @yegortimoshenko |
Mic92
reviewed
Jun 29, 2020
Mic92
reviewed
Jun 29, 2020
dell/xps/13-9343/default.nix
Outdated
| services.throttled.enable = lib.mkDefault true; | ||
|
|
||
| # This will save you money and possibly your life! | ||
| services.thermald.enable = true; |
There was a problem hiding this comment.
This seems like a good default for laptops in general. @yegortimoshenko should we enable it in the profile?
|
Should I use |
Yes. |
|
Thanks. I made the change. |
|
Thanks!! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea if
throttledandthermaldare needed sincecommon/pc/laptophastlp. I copied them from another profile.Also I wonder if
boot.extraModulePackages = [ config.boot.kernelPackages.broadcom_sta ];should be in the profile sincehardware-configuration.nixalready has it. I wonder if it could help people figure out that they need to make a custom iso with that driver to be able to install with the wifi. Maybe it could be noted in a README.https://wiki.archlinux.org/index.php/Dell_XPS_13_(9343)#Powersaving
I also wonder if this should be included or only noted in a README. If included I'm not sure how the user could disable it.