Fix #8230: Resolve ".." when opening files in .tar #8231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
requested changes
Jun 21, 2020
src/fileio.cpp
Outdated
| } | ||
| tokens.pop_back(); | ||
| resolved_name[0] = '\0'; | ||
| for (std::string token : tokens) { |
There was a problem hiding this comment.
Suggested change
| for (std::string token : tokens) { | |
| for (const std::string &token : tokens) { |
LordAro
reviewed
Jun 21, 2020
LordAro
approved these changes
Jun 21, 2020
LordAro
added
the
backport requested
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
Jul 30, 2020
LordAro
pushed a commit
that referenced
this pull request
Aug 9, 2020
glx22
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible solution. Not sure if my algorithm is optimal (but at least it's easy to understand).