vendor/lattice_machxo: suppport machXO3 #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… previous class name as user-alias and add an user-alias for machXO3 platform
whitequark
reviewed
Jun 21, 2020
README.md
Outdated
| @@ -43,6 +43,7 @@ nMigen can be used to target any FPGA or ASIC process that accepts behavioral Ve | |||
|
|
|||
| * Lattice iCE40 (toolchains: **Yosys+nextpnr**, LSE-iCECube2, Synplify-iCECube2); | |||
| * Lattice MachXO2 (toolchains: Diamond); | |||
| * Lattice MachXO3l (toolchains: Diamond); | |||
There was a problem hiding this comment.
Isn't the chip called MachXO3L (capital L)? E.g. in vendor docs.
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
=======================================
Coverage 82.02% 82.02%
=======================================
Files 36 36
Lines 6114 6114
Branches 1237 1237
=======================================
Hits 5015 5015
- Misses 923 924 +1
+ Partials 176 175 -1
Continue to review full report at Codecov.
|
whitequark
reviewed
Jun 21, 2020
nmigen/vendor/lattice_machxo_2_3l.py
Outdated
| @@ -4,10 +4,11 @@ | |||
| from ..build import * | |||
|
|
|||
|
|
|||
| __all__ = ["LatticeMachXO2Platform"] | |||
| __all__ = ["LatticeMachXO2Platform", "LatticeMachXO3lPlatform"] | |||
There was a problem hiding this comment.
Everywhere, not just in MachXO3L.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
machXO2 and machXO3l have same primitives: