Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chewing-editor: init at 0.1.1 Add package chewing-editor #91270

Merged
merged 2 commits into from Jul 5, 2020

Conversation

ShamrockLee
Copy link
Contributor

Motivation for this change

chewing-editor is the user phrase editor
for Chewing input method
(one of the most popular bopomofo Chinese input method)
Chewing IM memorize phrases input by the user automatically
or when the hot keys are pressed.
If applied, the commit will enable Chewing user to correct the phrases in the
database or add new ones, which is a crucial functionality of Chewing IM
that haven't been in NixOS.
The corresponded Packaging Request is #89554.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@iblech
Copy link
Contributor

iblech commented Jun 22, 2020

(Just a random passer-by.) Awesome, thank you for making NixOS more accessible for users of traditional Chinese! I confirm that the package builds here. :-)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/203

Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rewrite your git history so it is two separate commits. One that adds the package and then one that adds you as the maintainer.

@ShamrockLee
Copy link
Contributor Author

@ryantm
I have it split now.

@ShamrockLee ShamrockLee requested a review from ryantm July 5, 2020 18:06
chewing-editor is the user phrase editor
for Chewing input method (a widely used bopomofo Chinese input method)
Chewing IM memorize phrases input by the automatically
or when the hot keys are pressed.
With this package, users will be able to correct/add phrases in the
database. This is one of the fundamental functionality of Chewing IM
and it will be great to have it in NixOS.
The corresponded Packaging Request is NixOS#89554.
@ryantm
Copy link
Member

ryantm commented Jul 5, 2020

@ShamrockLee I redid the history to be just two commits and made it so the commit that adds the chewing-editor derivation can live on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants