Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firebase-tools: init at 8.4.3 #91208

Closed
wants to merge 0 commits into from
Closed

firebase-tools: init at 8.4.3 #91208

wants to merge 0 commits into from

Conversation

arri-cc
Copy link

@arri-cc arri-cc commented Jun 21, 2020 •
edited

Motivation for this change

Adds firebase-tools to nodePackages, a very popular cli for Firebase

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arri-cc arri-cc changed the title nodePackages.firebase-tools: init at 8.4.3 firebase-tools: init at 8.4.3 Jun 21, 2020
@arri-cc arri-cc closed this Jun 21, 2020
@arri-cc arri-cc reopened this Jun 21, 2020
@tadfisher
Copy link
Contributor

@arri-cc Can you rebase this?

@arri-cc
Copy link
Author

arri-cc commented Nov 10, 2020

@arri-cc Can you rebase this?

I'll take a look tonight or tomorrow

@arri-cc arri-cc closed this Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arri-cc @tadfisher @ryantm