Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hercules-ci-agent: init at 0.7.2 #91223

Merged
merged 1 commit into from Jun 21, 2020

Conversation

roberth
Copy link
Member

@roberth roberth commented Jun 21, 2020

Motivation for this change

Hercules CI is a continuous integration system that uses Nix as its foundation. Users run hercules-ci-agent themselves to execute their CI jobs. Packaging it in Nixpkgs will make installation easier. A NixOS module will be provided in a separate PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date -> meta fields are up to date and complete compared to pkgs.nix
  • Fits CONTRIBUTING.md.

@roberth roberth merged commit 838822a into NixOS:master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants