Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.mautrix: 0.5.4 -> 0.5.7 #91248

Merged
merged 1 commit into from Jun 22, 2020
Merged

pythonPackages.mautrix: 0.5.4 -> 0.5.7 #91248

merged 1 commit into from Jun 22, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jun 21, 2020 •
edited

Motivation for this change

Packaging mautrix-facebook (would there be interest to have this in nixpkgs?) and it needs mautrix>=0.5.6.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    3 packages built:
    - mautrix-telegram
    - python37Packages.mautrix (python37Packages.mautrix-appservice)
    - python38Packages.mautrix (python38Packages.mautrix-appservice)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Ma27 and nyanloutre June 21, 2020 18:54
@Ma27 Ma27 merged commit dca182d into NixOS:master Jun 22, 2020
@Munksgaard
Copy link
Contributor

would there be interest to have this in nixpkgs

Yes!

@mmilata mmilata deleted the mautrix-0.5.7 branch January 20, 2021 20:15
@mmilata
Copy link
Member Author

mmilata commented Jan 20, 2021

I'm not using mautrix-facebook anymore but here is the latest state:

Also @eyJhb may or may not be working on this package as well.

@eyJhb
Copy link
Member

eyJhb commented Jan 20, 2021

I have a working version, I can make a PR for it soon ! :) I want to rework the mautrix module as well. Thanks for the reminder @mmilata !

@Munksgaard
Copy link
Contributor

Sounds great @eyJhb, looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Ma27 Ma27 Awaiting requested review from Ma27

@nyanloutre nyanloutre Awaiting requested review from nyanloutre

Assignees
No one assigned
Labels
6.topic: python 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmilata @Munksgaard @eyJhb @Ma27