Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyvips: init at 2.1.11 #91209

Closed
wants to merge 3 commits into from
Closed

pyvips: init at 2.1.11 #91209

wants to merge 3 commits into from

Conversation

ccellado
Copy link
Contributor

Motivation for this change

Add this wrapper to nixpkgs.

Things done

Help needed!

Some basic things, but its not working, my goal is to make it build&link in API mode with libvips.
I cannot create this on my own, tried requesting but to no avail.

Hope for some experienced guidance here.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
Copy link
Contributor

  1. There's a merge conflict.
  2. You should convert this PR to a draft.

@jonringer
Copy link
Contributor

I sorted python-packages.nix, you'll need to replace the entry. Please sort it.

@ccellado
Copy link
Contributor Author

ccellado commented Sep 9, 2020

I've asked for help in creating proper .nix recipe for the package. Several months later all I got is comments about merge conflicts? Ok. Closing now, there is no point.

@ccellado ccellado closed this Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ccellado @doronbehar @jonringer @taikatytto